Export LLVM plugin entrypoint for windows shared library builds #115431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Symbol visibility macro to llvmGetPassPluginInfo so plugins export it for windows shared library builds with explicit symbol visibility macros enabled. This avoids the need for existing plugins having to manually add visibility macros to there llvmGetPassPluginInfo function to work on windows. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Open
40 tasks
compnerd
reviewed
Nov 11, 2024
|
@compnerd, can we make another review round? |
compnerd
requested changes
Nov 19, 2024
| extern "C" ::llvm::PassPluginLibraryInfo LLVM_ATTRIBUTE_WEAK | ||
| llvmGetPassPluginInfo(); | ||
| #endif |
There was a problem hiding this comment.
I think that we can share most of the declaration between the platforms, it is only the attribute that differs.
extern "C" ::llvm::PassPluginLibraryInfo
#if defined(_WIN32)
#if defined(LLVM_BUILD_LLVM_DYLIB)
__declspec(dllexport)
#endif
#else
LLVM_ATTRIBUTE_WEAK
#endif
llvmGetPassPluginInfo();There was a problem hiding this comment.
That looks a really painful way to declare it.
|
@fsfod, this one looks towards its final phase. Can you address the comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Symbol visibility macro to llvmGetPassPluginInfo so plugins export it for windows shared library builds with explicit symbol visibility macros enabled. This also avoids the need for existing plugins having to manually add visibility macros to there llvmGetPassPluginInfo function to work on windows.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.